5 Commits

Author SHA1 Message Date
Millian Lamiaux
d6d5f40359 ci: gate admin-web docker build on unit tests and remove admin-web job from ci.yml
- admin-web-docker.yml: add 'test' job (Node 22, npm ci, tsc --noEmit,
  vitest run) gated by the anti-[skip ci] guard, wire needs: [test] on
  build-validation and semantic-release, and needs: [semantic-release, test]
  on build-and-push. Tests now run as a gate before Docker build validation
  on PRs and before semantic-release on main.
- ci.yml: drop the redundant admin-web-test job (now covered by the test
  job in admin-web-docker.yml on PRs), remove the admin-web path filter
  and output from the changes job, simplify deploy-functions.needs.
- scripts/verify-admin-web-docker.sh: update check_workflow_jobs to expect
  4 jobs (test + build-validation + semantic-release + build-and-push) and
  check_workflow_needs to expect build-and-push needs [semantic-release, test]
  so the verify script stays green with the new job topology.
2026-07-13 15:44:52 +02:00
Millian Lamiaux
193e56a0b5 test(admin-web): fix 14 broken vitest tests and exclude e2e from run
- vitest.config.ts: add explicit exclude (e2e/**, playwright-report/**,
  test-results/**) spread with configDefaults.exclude to keep
  node_modules/dist filtering intact
- app/page.test.tsx: waitFor for async stats resolution, replace
  getAllByRole('article') with 'a [data-slot=card]' scoped queries
  (Getting Started card has no icon so we scope to the 3 stat cards inside
  <Link>), drop console.error assertion (production fetchStats destructures
  { count } from the resolved payload without throwing on
  { count: null, error }, so console.error is never called on that path)
- components/workout-form.test.tsx: mock sonner (toast.error/success with
  all methods stubbed) to replace obsolete window.alert assertions, wait for
  the custom Select trainer dropdown to mount before clicking, fill the
  exercise-name-0 input (default exercises state is [{name:""}] which fails
  validation), make insert/update mocks resolve on a macrotask so React can
  render the transient 'Saving...' loading state
- app/login/page.test.tsx: replace getByRole('heading') with getByText
  (shadcn CardTitle renders a <div>, not a semantic heading), extend sonner
  mock with toast.error, fix invalid-credentials mock to return a real
  Error instance (production supabase-js returns AuthError extends Error,
  so the err instanceof Error branch surfaces the real message)
- components/ui/dialog.test.tsx: skip jsdom-incompatible click-outside test
  (Radix Dialog closes via pointerDown on overlay, not reproducible in jsdom;
  covered by the Escape test + Playwright E2E), replace aria-modal assertion
  with role=dialog + aria-labelledby (modern Radix no longer emits aria-modal)

Scope: tests + config only. No production code change.
2026-07-13 15:44:37 +02:00
Millian Lamiaux
9cf7ea1f15 fix(ci): remove sudo from docker install — Gitea ubuntu runner is root without sudo
Some checks failed
Admin Web Docker / Docker Build Validation (pull_request) Successful in 1m2s
Admin Web Docker / Semantic Release (pull_request) Has been skipped
CI / Detect Changes (pull_request) Successful in 4s
Admin Web Docker / Build & Push Docker Image (pull_request) Has been skipped
CI / Admin Web CI (pull_request) Failing after 38s
CI / YouTube Worker (pull_request) Has been skipped
CI / Deploy (pull_request) Has been skipped
PR → Build → WiFi/USB Deploy → LGTM / Build & Deploy to iPhone (WiFi/USB) (pull_request) Failing after 3m8s
PR → Build → WiFi/USB Deploy → LGTM / Wait for LGTM comment (pull_request) Has been skipped
2026-07-13 14:15:32 +02:00
Millian Lamiaux
3dd044029e ci: trigger workflow on PR with build-only validation
Some checks failed
CI / Deploy (pull_request) Has been skipped
PR → Build → WiFi/USB Deploy → LGTM / Build & Deploy to iPhone (WiFi/USB) (pull_request) Failing after 2m37s
PR → Build → WiFi/USB Deploy → LGTM / Wait for LGTM comment (pull_request) Has been skipped
Admin Web Docker / Docker Build Validation (pull_request) Failing after 28s
Admin Web Docker / Semantic Release (pull_request) Has been skipped
CI / Detect Changes (pull_request) Successful in 4s
Admin Web Docker / Build & Push Docker Image (pull_request) Has been skipped
CI / Admin Web CI (pull_request) Failing after 38s
CI / YouTube Worker (pull_request) Has been skipped
2026-07-12 22:50:35 +02:00
Millian Lamiaux
cb86bf55b3 feat: add admin-web Docker build & push workflow with semantic-release
Some checks failed
CI / Detect Changes (pull_request) Successful in 4s
CI / Admin Web CI (pull_request) Failing after 39s
CI / YouTube Worker (pull_request) Has been skipped
CI / Deploy (pull_request) Has been skipped
PR → Build → WiFi/USB Deploy → LGTM / Build & Deploy to iPhone (WiFi/USB) (pull_request) Failing after 2m15s
PR → Build → WiFi/USB Deploy → LGTM / Wait for LGTM comment (pull_request) Has been skipped
2026-07-12 19:11:15 +02:00
11 changed files with 22 additions and 131 deletions

View File

@@ -106,15 +106,16 @@ jobs:
# 1. Try WiFi first (Xcode 15+ devicectl network discovery)
echo "📱 Trying WiFi install via devicectl..."
if xcrun devicectl device install app --device "$UDID" "$APP" > /tmp/devicectl.log 2>&1; then
xcrun devicectl device install app --device "$UDID" "$APP" 2>&1 | tail -3
if [ ${PIPESTATUS[0]} -eq 0 ]; then
echo "✅ Installed via WiFi"
exit 0
fi
tail -10 /tmp/devicectl.log
# 2. Fallback to USB via ios-deploy
echo "🔌 WiFi failed, trying USB..."
if ios-deploy --bundle "$APP" --id "$UDID" --justlaunch; then
ios-deploy --bundle "$APP" --id "$UDID" --justlaunch
if [ $? -eq 0 ]; then
echo "✅ Installed via USB"
exit 0
fi
@@ -122,7 +123,6 @@ jobs:
echo "❌ Install failed (both WiFi and USB)"
exit 1
- name: Post "Ready to test" comment
env:
GT_TOKEN: ${{ secrets.PR_API_TOKEN }}

View File

@@ -18,8 +18,17 @@
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>1.0</string>
<key>CFBundleURLTypes</key>
<array>
<dict>
<key>CFBundleURLSchemes</key>
<array>
<string>tabatago</string>
</array>
</dict>
</array>
<key>CFBundleVersion</key>
<string>2</string>
<string>1</string>
<key>NSHealthShareUsageDescription</key>
<string>TabataGo reads your health data to show fitness stats and personalize your workouts.</string>
<key>NSHealthUpdateUsageDescription</key>

View File

@@ -9,8 +9,6 @@
<string>health-records</string>
</array>
<key>com.apple.security.application-groups</key>
<array>
<string>group.fr.millianlmx.tabatago</string>
</array>
<array/>
</dict>
</plist>

View File

@@ -28,55 +28,12 @@ final class AudioService {
try audioSession.setCategory(
.playback,
mode: .default,
options: [.allowAirPlay, .allowBluetooth]
options: [.mixWithOthers, .allowAirPlay, .allowBluetooth]
)
try audioSession.setActive(true)
} catch {
print("[Audio] Session configuration failed: \(error)")
}
// Interruption Handler
NotificationCenter.default.addObserver(
forName: AVAudioSession.interruptionNotification,
object: nil,
queue: .main
) { [weak self] notification in
guard let self,
let typeValue = notification.userInfo?[AVAudioSessionInterruptionTypeKey] as? UInt,
let type = AVAudioSession.InterruptionType(rawValue: typeValue) else { return }
if type == .ended {
guard let optionsValue = notification.userInfo?[AVAudioSessionInterruptionOptionKey] as? UInt,
AVAudioSession.InterruptionOptions(rawValue: optionsValue).contains(.shouldResume) else { return }
do {
try self.audioSession.setActive(true)
} catch {
print("[Audio] Re-activation failed after interruption: \(error)")
}
}
}
// Route Change Handler
NotificationCenter.default.addObserver(
forName: AVAudioSession.routeChangeNotification,
object: nil,
queue: .main
) { [weak self] notification in
guard let self,
let reasonValue = notification.userInfo?[AVAudioSessionRouteChangeReasonKey] as? UInt,
let reason = AVAudioSession.RouteChangeReason(rawValue: reasonValue) else { return }
switch reason {
case .newDeviceAvailable, .oldDeviceUnavailable:
do {
try self.audioSession.setActive(true)
} catch {
print("[Audio] Route re-activation failed: \(error)")
}
default:
break
}
}
}
// Phase Audio Cues

View File

@@ -39,7 +39,6 @@ final class PlayerViewModel: ObservableObject {
@Published var isComplete: Bool = false
@Published var showExitConfirmation: Bool = false
@Published private(set) var completedSession: WorkoutSession? = nil
@Published var liveActivityError: String? = nil
// Track info for Live Activity set by View when music changes
var currentTrackTitle = ""
@@ -383,10 +382,7 @@ final class PlayerViewModel: ObservableObject {
// Dynamic Island / Live Activity
func syncActivity(shouldAlert: Bool = false) {
guard ActivityAuthorizationInfo().areActivitiesEnabled else {
liveActivityError = "Live Activities are disabled in Settings"
return
}
guard ActivityAuthorizationInfo().areActivitiesEnabled else { return }
guard isRunning else { return }
let isPlayingMusic = (phase == .work || phase == .rest) && isRunning && !isPaused
@@ -453,14 +449,8 @@ final class PlayerViewModel: ObservableObject {
attributes: attrs,
content: ActivityContent(state: state, staleDate: staleDate)
)
liveActivityError = nil
observeActivityState()
} catch let authError as ActivityAuthorizationError {
liveActivityError = "Live Activities: \(authError.localizedDescription)"
} catch {
let msg = error.localizedDescription
let truncated = msg.count > 200 ? String(msg.prefix(200)) + "" : msg
liveActivityError = "Live Activity error: \(truncated)"
print("❌ Failed to start Live Activity: \(error.localizedDescription)")
}
}

View File

@@ -66,40 +66,6 @@ struct PlayerView: View {
}
}
//
// Live Activity error banner (non-blocking)
//
if let error = vm.liveActivityError {
VStack {
HStack(spacing: 8) {
Image(systemName: "exclamationmark.triangle.fill")
.font(.caption)
.foregroundStyle(.yellow)
Text(error)
.font(.caption2.weight(.medium))
.foregroundStyle(.white.opacity(0.9))
Spacer()
Button {
vm.liveActivityError = nil
} label: {
Image(systemName: "xmark")
.font(.system(size: 10, weight: .bold))
.foregroundStyle(.white.opacity(0.6))
}
}
.padding(.horizontal, 16)
.padding(.vertical, 10)
.background(.ultraThinMaterial.opacity(0.9))
.clipShape(RoundedRectangle(cornerRadius: 12))
.padding(.horizontal, 16)
.padding(.top, 60)
Spacer()
}
.transition(.move(edge: .top).combined(with: .opacity))
.animation(.spring(duration: 0.3), value: vm.liveActivityError)
.zIndex(100)
}
//
// Layer 4 Compact timer ring (top-right corner)
//

View File

@@ -19,7 +19,7 @@
<key>CFBundleShortVersionString</key>
<string>1.0</string>
<key>CFBundleVersion</key>
<string>2</string>
<string>1</string>
<key>NSExtension</key>
<dict>
<key>NSExtensionPointIdentifier</key>

View File

@@ -19,7 +19,7 @@
<key>CFBundleShortVersionString</key>
<string>1.0</string>
<key>CFBundleVersion</key>
<string>2</string>
<string>1</string>
<key>NSHealthShareUsageDescription</key>
<string>TabataGo reads your heart rate and calories during workouts.</string>
<key>NSHealthUpdateUsageDescription</key>

View File

@@ -4,6 +4,8 @@
<dict>
<key>CFBundleDevelopmentRegion</key>
<string>$(DEVELOPMENT_LANGUAGE)</string>
<key>CFBundleDisplayName</key>
<string>TabataGoWidget</string>
<key>CFBundleExecutable</key>
<string>$(EXECUTABLE_NAME)</string>
<key>CFBundleIdentifier</key>

View File

@@ -553,7 +553,7 @@ struct WorkoutLiveActivity: Widget {
.contentMargins(.leading, 8, for: .expanded)
.contentMargins(.trailing, 8, for: .expanded)
.contentMargins(.bottom, 6, for: .expanded)
.widgetURL(URL(string: "tabatago://workout"))
.widgetURL(URL(string: "tabatago://workout")!)
}
.supplementalActivityFamilies([.small, .medium])
}

View File

@@ -60,10 +60,6 @@ targets:
SUPABASE_ANON_KEY: $(SUPABASE_ANON_KEY)
REVENUECAT_API_KEY: $(REVENUECAT_API_KEY)
POSTHOG_API_KEY: $(POSTHOG_API_KEY)
NSSupportsLiveActivities: true
NSSupportsLiveActivitiesFrequentUpdates: true
UIBackgroundModes:
- audio
entitlements:
path: TabataGo/Resources/TabataGo.entitlements
properties:
@@ -80,8 +76,6 @@ targets:
- target: TabataGoWatch
embed: true
- target: TabataGoWidget
embed: true
settings:
base:
PRODUCT_BUNDLE_IDENTIFIER: fr.millianlmx.tabatago
@@ -162,30 +156,6 @@ targets:
TARGETED_DEVICE_FAMILY: "4"
WATCHOS_DEPLOYMENT_TARGET: "11.0"
TabataGoWidget:
type: app-extension
platform: iOS
deploymentTarget: "26.0"
sources:
- path: TabataGoWidget
excludes:
- "**/.DS_Store"
- path: TabataGo/Models/WorkoutActivityAttributes.swift
- path: TabataGo/Models/MusicActivityAttributes.swift
info:
path: TabataGoWidget/Info.plist
properties:
NSExtension:
NSExtensionPointIdentifier: com.apple.widgetkit-extension
NSSupportsLiveActivities: true
NSSupportsLiveActivitiesFrequentUpdates: true
settings:
base:
PRODUCT_BUNDLE_IDENTIFIER: fr.millianlmx.tabatago.widget
IPHONEOS_DEPLOYMENT_TARGET: "26.0"
TARGETED_DEVICE_FAMILY: "1"
ENABLE_PREVIEWS: YES
TabataGoTests:
type: bundle.unit-test
platform: iOS
@@ -215,7 +185,6 @@ schemes:
build:
targets:
TabataGo: all
TabataGoWidget: all
run:
config: Debug
archive: